Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve health check log messages #29787

Merged
merged 2 commits into from
Jul 25, 2023
Merged

chore: improve health check log messages #29787

merged 2 commits into from
Jul 25, 2023

Conversation

sampaiodiego
Copy link
Member

ARCH-1120

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner July 11, 2023 19:45
@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9b894bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #29787 (9b894bc) into develop (45a8943) will decrease coverage by 1.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29787      +/-   ##
===========================================
- Coverage    48.54%   47.32%   -1.22%     
===========================================
  Files          700      695       -5     
  Lines        13864    13734     -130     
  Branches      2441     2436       -5     
===========================================
- Hits          6730     6500     -230     
- Misses        6757     6872     +115     
+ Partials       377      362      -15
Flag Coverage Δ
e2e 45.29% <ø> (-1.34%) ⬇️
unit 64.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 6.4.0 milestone Jul 24, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 24, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 24, 2023
@ggazzo ggazzo merged commit 3eed4a7 into develop Jul 25, 2023
35 of 37 checks passed
@ggazzo ggazzo deleted the improve-health-check-log-message branch July 25, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sampaiodiego @ggazzo @KevLehman